Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable test 'CallThisPointerIsNullRainyDay' #1038

Closed
wants to merge 1 commit into from
Closed

Conversation

maxz-lab
Copy link
Contributor

The test case 'CallThisPointerIsNullRainyDay' failed after NDK 25 upgrade.
Add the required compilation flag and re-enable the test.

b/288107039

The test case 'CallThisPointerIsNullRainyDay' failed after NDK 25 upgrade.
Add the required compilation flag and re-enable the test.

b/288107039
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #1038 (3b6d1a5) into main (0edf3d6) will increase coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
+ Coverage   56.87%   56.90%   +0.02%     
==========================================
  Files        1898     1898              
  Lines       94100    94100              
==========================================
+ Hits        53518    53543      +25     
+ Misses      40582    40557      -25     

see 6 files with indirect coverage changes

Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the tests run, this lgtm. In the future, please ping reviewers if it's waiting too long

@maxz-lab maxz-lab closed this Sep 28, 2023
@maxz-lab maxz-lab deleted the maxz-lab-ndk25 branch September 28, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants